Differential D21844

[WriteTransactionTest] Clear mixup of QString and QByteArray
ClosedPublic
Actions

Authored by bruns on Jun 16 2019, 1:04 PM.

Details

Reviewers
ngraham
astippich
poboiko
Group Reviewers
Baloo
Commits
R293:3e3cd7e63336: [WriteTransactionTest] Clear mixup of QString and QByteArray
Summary

touchFile expects a QString argument, not QByteArray. Use
QFile::encodeFileName() instead of QString::toUtf8().

Test Plan

ctest

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Jun 16 2019, 1:04 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptJun 16 2019, 1:04 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Jun 16 2019, 1:04 PM
ngraham accepted this revision.Jun 16 2019, 5:07 PM

Whoops!

This revision is now accepted and ready to land.Jun 16 2019, 5:07 PM
Closed by commit R293:3e3cd7e63336: [WriteTransactionTest] Clear mixup of QString and QByteArray (authored by bruns). · Explain WhyJun 16 2019, 5:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 59941

View Options

autotests/integration/writetransactiontest.cpp

Loading...