[PostingIterator] Move positions() method to VectorPositionInfoIterator
ClosedPublic
Actions

Authored by bruns on Jun 15 2019, 7:34 PM.

Details

Reviewers

ngraham
astippich
poboiko

Group Reviewers

Baloo

Commits

R293:381e2cd92379: [PostingIterator] Move positions() method to VectorPositionInfoIterator

Summary

The positions() method is only used inside the PhraseAndIterator and
requires either a VectorPositionInfoIterator or a DBPositionIterator,
as these are the only ones reimplementing the positions() method.

Actually, VectorPositionInfoIterator and DBPositionIterator have
identical implementations, save the constructor argument. The conversion
of the constructor argument can be trivially inlined and DBPositionIterator
can be removed completely.

This indirectly improves the test coverage (VectorPositionInfoIterator is
used in the PhraseAndIteratorTest) and removes duplicate code.

Test Plan

ctest

Diff Detail

Repository

R293 Baloo

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

bruns created this revision.Jun 15 2019, 7:34 PM

Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptJun 15 2019, 7:34 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

bruns requested review of this revision.Jun 15 2019, 7:34 PM

Harbormaster completed remote builds in B12871: Diff 59889.Jun 15 2019, 7:34 PM

ngraham accepted this revision.Jun 16 2019, 5:12 PM

This revision is now accepted and ready to land.Jun 16 2019, 5:12 PM

Closed by commit R293:381e2cd92379: [PostingIterator] Move positions() method to VectorPositionInfoIterator (authored by bruns). · Explain WhyJun 16 2019, 5:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/unit/engine/phraseanditeratortest.cpp (4 lines)
M			autotests/unit/engine/positiondbtest.cpp (4 lines)
M			src/engine/phraseanditerator.h (5 lines)
M			src/engine/phraseanditerator.cpp (5 lines)
M			src/engine/positiondb.h (4 lines)
M			src/engine/positiondb.cpp (44 lines)
M			src/engine/postingiterator.h (2 lines)
M			src/engine/postingiterator.cpp (5 lines)
M			src/engine/transaction.cpp (7 lines)
M			src/engine/vectorpositioninfoiterator.h (2 lines)
M			src/engine/vectorpositioninfoiterator.cpp (4 lines)