| davidedmundson | |
| ngraham |
| Plasma |
As of SDDM release 0.16.0 it advised to use /etc/sddm.conf.d/ as the directory for user settings.
This patch aims to achieve it by saving in that very same directory under the filename "kde_settings.conf".
It must also remove identical entries from the old "sddm.conf" file because SDDM will simply load them instead of new user set values.
BUG: 386241
FIXED-IN: 5.17
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| sddmauthhelper.cpp | ||
|---|---|---|
| 90 | if something is going into the file "kde_settings.conf" then we want to remove it from sddmOldConfig Nothing in args is sent with this filename | |
| src/sddmkcm.cpp | ||
| 60 | This file doesn't need to be changed at all | |
| 74–75 | as it's all done here | |
| src/themesmodel.cpp | ||
| 93 ↗ | (On Diff #59883) | this needs to be using the same logic as sddmkcm.cpp probably easier if they share the same kconfig instance |
| sddmauthhelper.cpp | ||
|---|---|---|
| 90 | Thanks! This is what I was not figuring out properly all along. | |
I argued in https://bugs.kde.org/show_bug.cgi?id=386241 that this is the wrong way. Any reason you implemented this anyway?
I would actually note that the file should be 0_kde_settings.conf (assuming/hoping sddm orders the configs) otherwise a user can manually create best_config.conf and get overridden by what was set in the KCM what with k being loaded after b.
Users shouldn't be creating random files in this directory.
But if considering the possibility, according to tests configs are ordered alphabetically so we'd need to have a z_kde_settings.conf (if not intervening in SDDM).