Convert all state checks to KWindowInfo::hasState().
ClosedPublic
Actions

Authored by hein on Jul 15 2016, 10:11 AM.

Details

Reviewers

Group Reviewers

Commits

Summary

We've had bad experiences with state() in a plasma-framework testcase
and this is more readable regardless.

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

hein retitled this revision from to Convert all state checks to KWindowInfo::hasState()..

hein updated this object.

hein edited the test plan for this revision. (Show Details)

hein added reviewers: Plasma, graesslin.

hein added a subscriber: plasma-devel.

graesslin edited edge metadata.

This revision is now accepted and ready to land.Jul 15 2016, 11:02 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			libtaskmanager/xwindowtasksmodel.cpp (32 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	5201	56ea0f5		Jul 15 2016, 10:11 AM	★	★
Diff 2	5205	56ea0f5	rPLASMAWORKSPACEf4a1d740f1e4428f31fd13f66ec2a54bf467dd35	Jul 15 2016, 10:11 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
5b616fdeb365	2c0169988697	56ea0f5947ac	Eike Hein	Convert all state checks to KWindowInfo::hasState(). (Show More…)	Jul 15 2016, 10:10 AM