Redo update website
ClosedPublic

Authored by ognarb on Jun 14 2019, 9:20 AM.

Details

Summary

Revert last commit and apply it again
Last commit 20b7949a671e83f5f8126dce2285f39c3db0dbf1 was not correctly
pplied (directory structure was broken and some files were missing).
So I reverted it and applied it again with git apply D20701.diff

Test Plan
bundle install --path vendor/bundle
bundle exec jekyll serve

Diff Detail

Repository
R935 Konsole Website
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ognarb created this revision.Jun 14 2019, 9:20 AM
Restricted Application added a project: Konsole. · View Herald TranscriptJun 14 2019, 9:20 AM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
ognarb requested review of this revision.Jun 14 2019, 9:20 AM
ognarb retitled this revision from Revert last commit and apply it again Last commit was not correctly applied (directory structure was broken and some files were missing). So I reverted it and applied it again with git apply D?????.diff to Revert last commit and apply it againLast commit was not correctly applied (directory structure was broken and some files were missing).So I reverted it and applied it again with git apply D?????.diff.Jun 14 2019, 9:21 AM
ognarb edited the summary of this revision. (Show Details)
ognarb edited the test plan for this revision. (Show Details)
ognarb retitled this revision from Revert last commit and apply it againLast commit was not correctly applied (directory structure was broken and some files were missing).So I reverted it and applied it again with git apply D?????.diff to Revert last commit and apply it again.
ognarb edited the summary of this revision. (Show Details)
ognarb edited the summary of this revision. (Show Details)

Thanks, I'll work on this weekend and try to get it committed correctly.

hindenburg accepted this revision.Jun 15 2019, 2:01 PM
hindenburg retitled this revision from Revert last commit and apply it again to Redo update website.
hindenburg edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Jun 15 2019, 2:02 PM
This revision was automatically updated to reflect the committed changes.

Hello @bcooksley, could you please help me and take a look why in the log (https://binary-factory.kde.org/job/Website_konsole-kde-org/5/execution/node/17/log/), I get an error message that jekyll-3.8 is not available but when I try to build the docker file, I get a message that jekyll-3.8.5 was successfully installed.
Thanks

That message was occurring because your Gemfile specified an exact version of Jekyll, which i've now fixed.
While this has allowed the generation to proceed further, unfortunately it still fails due to encoding issues.

https://binary-factory.kde.org/job/Website_konsole-kde-org/6/console

That message was occurring because your Gemfile specified an exact version of Jekyll, which i've now fixed.
While this has allowed the generation to proceed further, unfortunately it still fails due to encoding issues.

https://binary-factory.kde.org/job/Website_konsole-kde-org/6/console

Ok, I published a new version of jekyll-kde-theme. This should fix the encoding issues. The docker image need to be rebuilded to fetch the new version of the theme and the ci job need to be restarted. Hope this is the last issue.

Thanks for that fix - the site now generates successfully and has been automatically deployed.
https://binary-factory.kde.org/job/Website_konsole-kde-org/7/console

Thanks for that fix - the site now generates successfully and has been automatically deployed.
https://binary-factory.kde.org/job/Website_konsole-kde-org/7/console

Yeah :D