See D15739
Details
Details
Diff Detail
Diff Detail
- Repository
- R318 Dolphin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I may need to add some sort of "#if KIO_VERSION < QT_VERSION_CHECK(5,60,0)" all over the place.
I have tried it but I haven't found similar patterns to base upon.
If I don't, it will make dolphin tests depends on kio master/5.60, unless this is tolerable.
I don't know the expectancies on tests.
Your call @elvisangelaccio.
Comment Actions
Probably makes sense to bump the Frameworks dependency version instead (safe since we're still in master development), but yeah, it's @elvisangelaccio's call.
Comment Actions
I'd avoid to bump the KF5 version only because of a test.
What we can do instead is to add the following check in src/tests/CMakeLists.txt :
if (KIO_VERSION VERSION_GREATER_EQUAL "5.60.0") ecm_add_test(placesitemmodeltest.cpp ...) endif()