Don't track subsystem status
ClosedPublic

Authored by broulik on Jun 13 2019, 5:50 PM.

Details

Summary

So far it was unused and we typically just read the user's preferences rather than checking what modules have been loaded.
For hiding unsupported settings (D21113) I am going to query for the status explicitly anyway since at the point the options page comes up the extension is most likely already running.

Test Plan
  • Played a video, disabled media controls, reloaded page, media controls were gone, re-enabled them, reloaded page, media controls are there again
  • When using an older host, prints warnings about "don't know what to do with message $module loaded" on extension dev console but should do no harm

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jun 13 2019, 5:50 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 13 2019, 5:50 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jun 13 2019, 5:50 PM
broulik added a reviewer: fvogt.
broulik edited the test plan for this revision. (Show Details)
fvogt accepted this revision.Jun 13 2019, 8:56 PM

Indeed unused, but I wonder whether doing it explicitly in D21113 is prettier...

This revision is now accepted and ready to land.Jun 13 2019, 8:56 PM

I think in the options page we don't really have a choice since it's a separate page opened by the user when the extension is already running.
If we ever do breaking changes in the extension script and need to check it, we can still reintroduce something.

This revision was automatically updated to reflect the committed changes.