Polish Context View
ClosedPublic
Actions

Authored by ngraham on Jun 12 2019, 5:26 PM.

Details

Reviewers

Group Reviewers

Elisa
VDG

Commits

R255:512869f27cfb: Polish Context View

Summary

This patch gives the Context View some visual polish. Changes include:

Remove the margins from the the album art slice
Move to a more visually pleasing centered layout
Remove Album Artist from metadata section, sicne it's visible in the subtitle if present
Add horizontal lines around metadata section for visual separation
Make labels not bold anymore
Remove "Lyrics" header (it's obvious that the words are lyrics)
Clean up the code a bit

Test Plan

Before:

After:

Diff Detail

Repository

R255 Elisa

Branch

polish-context-view (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 12739
Build 12757: arc lint + arc unit

ngraham requested review of this revision.Jun 12 2019, 5:26 PM

ngraham created this revision.

Harbormaster completed remote builds in B12739: Diff 59675.Jun 12 2019, 5:26 PM

ngraham mentioned this in D21776: Implement new Header toolbar style for main view.Jun 12 2019, 9:32 PM

Thanks for your work.

It really looks nice.

I am missing time to do a detailed review right now. I will try my best.

I have just a small remark about the bold removal. It is perhaps harder to read without it. Maybe, another way to better separate the category from the data could help ?

I can add back the bold:

I originally removed it because I thought the view looked kind of visually overwhelming and left-heavy with so much bold, but adding it back, I don't hate it so much.

Make the MetaDataDelegate labels bold again

Harbormaster completed remote builds in B12837: Diff 59832.Jun 14 2019, 10:02 PM

Also, take your time, no rush. :)

Thanks for your work.

This revision is now accepted and ready to land.Jun 24 2019, 8:26 PM

You're very welcome! Working on Elisa is just so much fun. :)

Closed by commit R255:512869f27cfb: Polish Context View (authored by ngraham). · Explain WhyJun 24 2019, 8:31 PM

This revision was automatically updated to reflect the committed changes.

ngraham mentioned this in R255:7160095af12f: Implement new Header toolbar style for main view.Jul 7 2019, 1:35 AM

Revision Contents
Changeset List

		Path
M		src/CMakeLists.txt (1 line)
M		src/models/trackcontextmetadatamodel.cpp (1 line)
M		src/qml/ContextView.qml (99 lines)
D	M	src/qml/ContextViewLyrics.qml (48 lines)
M		src/qml/MetaDataDelegate.qml (5 lines)
M		src/resources.qrc (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	59675	00b32e0		Jun 12 2019, 5:26 PM	★	★
Diff 2	59832	00b32e0	Make the MetaDataDelegate labels bold again	Jun 14 2019, 10:02 PM	★	★
Diff 3	60618	be00ded	R255:512869f27cfb11971645d759388d2671e1a811b7	Jun 24 2019, 8:31 PM	★	★