Polish Context View

Authored by ngraham on Jun 12 2019, 5:26 PM.


Group Reviewers
R255:512869f27cfb: Polish Context View

This patch gives the Context View some visual polish. Changes include:

  • Remove the margins from the the album art slice
  • Move to a more visually pleasing centered layout
  • Remove Album Artist from metadata section, sicne it's visible in the subtitle if present
  • Add horizontal lines around metadata section for visual separation
  • Make labels not bold anymore
  • Remove "Lyrics" header (it's obvious that the words are lyrics)
  • Clean up the code a bit
Test Plan



Diff Detail

R255 Elisa
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
ngraham requested review of this revision.Jun 12 2019, 5:26 PM
ngraham created this revision.

Thanks for your work.

It really looks nice.

I am missing time to do a detailed review right now. I will try my best.

I have just a small remark about the bold removal. It is perhaps harder to read without it. Maybe, another way to better separate the category from the data could help ?

I can add back the bold:

I originally removed it because I thought the view looked kind of visually overwhelming and left-heavy with so much bold, but adding it back, I don't hate it so much.

ngraham updated this revision to Diff 59832.Jun 14 2019, 10:02 PM

Make the MetaDataDelegate labels bold again

Also, take your time, no rush. :)

mgallien accepted this revision.Jun 24 2019, 8:26 PM

Thanks for your work.

This revision is now accepted and ready to land.Jun 24 2019, 8:26 PM

You're very welcome! Working on Elisa is just so much fun. :)

This revision was automatically updated to reflect the committed changes.