do not use legacy app_icon helper on klipper
ClosedPublic

Authored by sitter on Jun 12 2019, 12:32 PM.

Details

Summary

kde4_add_app_icon is fairly deprecated. additionally the call itself
was madness because it actually pulls the icon out of oxygen in the install
location. that is assuming the icon theme is even installed at build time
(which is probably always not true in our binary factorization
environments). lastly the app_icon helper is only useful to pick up
icons for osx and windows, neither are target platforms for plasma.

remove the app_icon call entirely until a use for it arises, which should
be... never... unless we decide that we want to replace explorer.exe ;)

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Jun 12 2019, 12:32 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 12 2019, 12:32 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.Jun 12 2019, 12:32 PM
davidedmundson accepted this revision.Jun 12 2019, 12:43 PM
This revision is now accepted and ready to land.Jun 12 2019, 12:43 PM
This revision was automatically updated to reflect the committed changes.