Port all plasma workspace to new libkworkspace API
ClosedPublic

Authored by davidedmundson on Jun 12 2019, 11:23 AM.

Details

Summary

ContainmentActions had some old windows code was dropped as that's
clearly unused.

logout and leave actions now enable/disable at runtime, so in future can
respond to config changes when that's added to libkworkspace.

DataEngines and the krunner code should have no visible changes

Test Plan

Left from the desktop and from krunner
Changed the default action in ksmserver's kcm
Confirmed that changes the default leave action changed

Diff Detail

Repository
R120 Plasma Workspace
Branch
kworkspace3
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12716
Build 12734: arc lint + arc unit
Restricted Application added a project: Plasma. · View Herald TranscriptJun 12 2019, 11:23 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Jun 12 2019, 11:23 AM
broulik added inline comments.
containmentactions/contextmenu/menu.cpp
103

Indentation

dataengines/powermanagement/powermanagementjob.cpp
62

Pointless return

dataengines/powermanagement/powermanagementjob.h
43

Where is it being initialized?

runners/sessions/sessionrunner.cpp
266

This got lost. Ideally that also followed the "automatically lock" setting like everywhere else, cf. SessionsModel

davidedmundson marked 4 inline comments as done.

update

broulik accepted this revision.Jan 30 2020, 10:13 AM
This revision is now accepted and ready to land.Jan 30 2020, 10:13 AM
This revision was automatically updated to reflect the committed changes.