Differential D21762

do not use long deprecated QString::toAscii
ClosedPublic
Actions

Authored by sitter on Jun 12 2019, 10:40 AM.

Details

Reviewers
hein
apol
Commits
R120:4cf47ad6818d: do not use long deprecated QString::toAscii
Summary

concatenate qstrings instead

Test Plan

builds

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Jun 12 2019, 10:40 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 12 2019, 10:40 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.Jun 12 2019, 10:40 AM
apol added a subscriber: apol.Jun 12 2019, 12:02 PM
apol added inline comments.
libtaskmanager/waylandtasksmodel.cpp
350

It's using weird API we shouldn't be using. It's creating a QString after all so I'd do:
return QStringLiteral("windowsystem/winid+") + uuid.toString();

sitter updated this revision to Diff 60563.Jun 24 2019, 10:22 AM

concat qstrings as suggested by @apol

sitter updated this revision to Diff 60564.Jun 24 2019, 10:23 AM

and update again because arcanist hates me

sitter edited the summary of this revision. (Show Details)Jun 24 2019, 10:23 AM
apol accepted this revision.Jun 24 2019, 10:25 AM
This revision is now accepted and ready to land.Jun 24 2019, 10:25 AM
Closed by commit R120:4cf47ad6818d: do not use long deprecated QString::toAscii (authored by sitter). · Explain WhyJun 24 2019, 10:44 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 60567

View Options

libtaskmanager/waylandtasksmodel.cpp

Loading...