[ksmserver] Drop internal loading of alternative window managers
ClosedPublic
Actions

Authored by davidedmundson on Jun 12 2019, 12:24 AM.

Details

Reviewers

broulik
apol

Group Reviewers

Plasma

Commits

R120:e89473103c5b: [ksmserver] Drop internal loading of alternative window managers
R120:e900d0df4877: ksmserver: Drop internal loading of alternative window managers

Summary

ksmserver's loading of other window manager relies on files in
share/windowmanagers/$name.desktop with the Exec line of the window
manager.

This was something previously installed by plasma-desktop and removed in

All this code path is now redundant as well as the wmChanged DBus

method used by the deleted KCM.

Setting KDEWM manually will still work as before.

Test Plan

Logged in
Got kwin as before

Diff Detail

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

davidedmundson created this revision.Jun 12 2019, 12:24 AM

Restricted Application added a project: Plasma. · View Herald TranscriptJun 12 2019, 12:24 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

davidedmundson requested review of this revision.Jun 12 2019, 12:24 AM

Harbormaster completed remote builds in B12705: Diff 59629.Jun 12 2019, 12:24 AM

davidedmundson retitled this revision from ksmserver: Drop internal loading of alternative window managers to [ksmserver] Drop internal loading of alternative window managers.Jun 12 2019, 9:38 AM

broulik accepted this revision.Jun 12 2019, 10:29 AM

This revision is now accepted and ready to land.Jun 12 2019, 10:29 AM

apol accepted this revision.Jun 12 2019, 10:30 AM

Closed by commit R120:e89473103c5b: [ksmserver] Drop internal loading of alternative window managers (authored by davidedmundson). · Explain WhyJun 12 2019, 8:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			ksmserver/KSMServerInterface.h (2 lines)
M			ksmserver/org.kde.KSMServerInterface.xml (1 line)
M			ksmserver/server.h (2 lines)
M			ksmserver/server.cpp (54 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	59629	cac7af8		Jun 12 2019, 12:24 AM	★	★
Diff 2	59685	0916d97	R120:e89473103c5bd592dd4c5b7865129f8976f0d701	Jun 12 2019, 8:30 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
a39f263352d2	75d725843af9	cac7af89b7eb	David Edmundson	ksmserver: Drop internal loading of alternative window managers (Show More…)	Jun 12 2019, 12:14 AM