Replace QMessageBox by KMessageBox
AbandonedPublic

Authored by schwarzer on Jun 11 2019, 10:04 PM.

Details

Reviewers
None
Group Reviewers
KDE Games
Summary

Krazy complains about using QMessageBox here.

Diff Detail

Repository
R412 KShisen
Lint
Lint Skipped
Unit
Unit Tests Skipped
schwarzer created this revision.Jun 11 2019, 10:04 PM
Restricted Application added a subscriber: kde-games-devel. · View Herald TranscriptJun 11 2019, 10:04 PM
schwarzer requested review of this revision.Jun 11 2019, 10:04 PM
aacid added a subscriber: aacid.Jun 11 2019, 10:08 PM

at this point i'd say that krazy warning is a bit old fashioned, but sure, won't hurt either

schwarzer added a comment.EditedJun 12 2019, 8:53 AM

Hmm, that was exactly my thought when I saw these Krazy issues. I think to remember exactly the opposite suggestion from a few years ago where Krazy said, we should use the equivalent Qt classes. Am I remembering correctly?

aacid added a comment.Jun 12 2019, 8:30 PM

Depends, KUrl? Yes Kurl is deprecated and you should use QUrl

KMessageBox is not deprecated and provides some more functionality than QMessageBox so it's ok to use

Yes, I re-read the KF5 porting notes and I guess the KFoo -> QFoo thingy was a misconception based on the deprecation of quite some the KDE 4 KFoo classes.
Thanks for your comments. :)