Differential D21740

Make text from Dolphin's information panel copyable
ClosedPublic
Actions

Authored by ghuwe on Jun 10 2019, 11:34 PM.

Details

Reviewers
ngraham
Group Reviewers
Baloo
Dolphin
Commits
R824:e5cc92b87ef1: Make text from Dolphin's information panel copyable
Summary

Fixed text from Dolphin's information panel not being copyable by adding the correct text interaction flags to the label.

BUG: 408359
FIXED-IN: 19.08.0

Diff Detail

Repository
R824 Baloo Widgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ghuwe created this revision.Jun 10 2019, 11:34 PM
Restricted Application added a subscriber: Baloo. · View Herald TranscriptJun 10 2019, 11:34 PM
ghuwe requested review of this revision.Jun 10 2019, 11:34 PM
ghuwe added a reviewer: Baloo.Jun 11 2019, 1:04 AM
ghuwe updated this revision to Diff 59575.Jun 11 2019, 5:18 AM

Added text interaction flag to the value widget too, so the actual value, not only the "key", is selectable

ghuwe removed reviewers: Dolphin, Baloo.Jun 11 2019, 6:07 AM
ghuwe added reviewers: Baloo, Dolphin.
ghuwe removed a subscriber: Baloo.
ghuwe added subscribers: Baloo, Dolphin.
ngraham accepted this revision.Jun 11 2019, 12:57 PM
ngraham added a subscriber: ngraham.

Perfect! Thanks very much for the patch.

This revision is now accepted and ready to land.Jun 11 2019, 12:57 PM
ngraham retitled this revision from Fixed text from Dolphin's information panel not being copyable to Make text from Dolphin's information panel copyable.Jun 11 2019, 12:58 PM
ngraham edited the summary of this revision. (Show Details)
Closed by commit R824:e5cc92b87ef1: Make text from Dolphin's information panel copyable (authored by ghuwe, committed by ngraham). · Explain WhyJun 11 2019, 12:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/filemetadatawidget.cpp (1 line)
Msrc/widgetfactory.cpp (1 line)

Diff 59595

View Options

src/filemetadatawidget.cpp

Loading...
View Options

src/widgetfactory.cpp

Loading...