Removing dead code - activity-event-handling private slots
ClosedPublic

Authored by ivan on Jul 14 2016, 3:24 PM.

Details

Summary

A few private slots handling the events of Activity objects
have been lingering in ShellCorona never to be called.
I've grepped both plasma-desktop and plasma-workspace for these
(even though they are private slots) and they seem not to be
used anywhere.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ivan updated this revision to Diff 5172.Jul 14 2016, 3:24 PM
ivan retitled this revision from to Removing dead code - activity-event-handling private slots.
ivan updated this object.
ivan edited the test plan for this revision. (Show Details)
ivan added reviewers: Plasma, mart, sebas, davidedmundson.
Restricted Application added a project: Plasma. · View Herald TranscriptJul 14 2016, 3:24 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ivan updated this object.Jul 14 2016, 3:25 PM
davidedmundson added inline comments.Jul 14 2016, 3:29 PM
shell/shellcorona.cpp
1588

we use this one

you've even updated the line that's using it in this very patch.

ivan marked an inline comment as done.Jul 14 2016, 3:34 PM
ivan added inline comments.
shell/shellcorona.cpp
1588

It is using activityRemoved(QString), not activityRemoved(), It would not compile otherwise after the change to Qt5 connect syntax :)

mart accepted this revision.Jul 14 2016, 3:47 PM
mart edited edge metadata.
This revision is now accepted and ready to land.Jul 14 2016, 3:47 PM
This revision was automatically updated to reflect the committed changes.
ivan marked an inline comment as done.