Make guiding more robust
ClosedPublic

Authored by wreissenberger on Jun 10 2019, 9:41 PM.

Details

Summary

This diff contains several improvements to the Scheduler and Guiding modules:

  1. Directly skip scheduler stage to capturing when guiding is already running. During the scheduler startup, the scheduler module recognizes if guiding is already running and directly jumps to capturing.
  2. Recognizing settling errors and handle them as aborted guiding. When using PHD2 as guider, EKOS recognizes settling errors. They occur for example when no guiding star can be found during the attempt to start guiding.
  3. Restart guiding with increasing delay. When a guiding problem occurs while starting the guiding, restarting guiding is delayed by an increasing delay.
Test Plan

Ad 1: First start guiding and then start a scheduler job that requires guiding. Check if the job starts capturing. Without this diff, the scheduler hangs in the guiding stage.
Ad 2: Change the PHD2 exposure time to a very low value so that no guiding star can be found. Then start a scheduler job that requires guiding. Check if the scheduler tries to re-start guiding.
Ad 3: Similar as 2. Check if starting the guider is delayed by an increasing amount of time.

Diff Detail

Repository
R321 KStars
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
wreissenberger created this revision.Jun 10 2019, 9:41 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptJun 10 2019, 9:41 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
wreissenberger requested review of this revision.Jun 10 2019, 9:41 PM
wreissenberger edited the summary of this revision. (Show Details)Jun 10 2019, 9:43 PM

I didn't test yet, but this seems just great. You're addressing real problems there. There are probably a few Bugzilla issues that could get resolved with this.

mutlaqja accepted this revision.Jun 11 2019, 6:23 AM

This looks good. Have to test it though with internal guider as well.

This revision is now accepted and ready to land.Jun 11 2019, 6:23 AM

I am primarily working with PHD2. I've tested #1 also with the internal guider, it showed the same problem as PHD2 and should be fixed. #2 is PHD2 specific and #3 should work with all guiders.

This revision was automatically updated to reflect the committed changes.