Differential D21728

Port away from KTimeZone usage in KolabBase
ClosedPublic
Actions

Authored by vkrause on Jun 10 2019, 4:31 PM.

Details

Reviewers
mlaurent
Commits
R44:ebc918ce04bd: Port away from KTimeZone usage in KolabBase
Summary

A bit messy as this relied on a subtle behavior difference to QTimeZone,
unit tests work as before.

Diff Detail

Repository
R44 KDE PIM Runtime
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Jun 10 2019, 4:31 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptJun 10 2019, 4:31 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.Jun 10 2019, 4:31 PM
mlaurent added a subscriber: mlaurent.Jun 10 2019, 5:33 PM
mlaurent added inline comments.
resources/kolab/pimkolab/autotests/testhelpers.h
23

still ktimezone.h here ?

vkrause added inline comments.Jun 10 2019, 5:56 PM
resources/kolab/pimkolab/autotests/testhelpers.h
23

yep, now needed here as it's no longer included in the other header, due to the toString(const KDateTime &dt) below

This revision is now accepted and ready to land.Jun 10 2019, 6:10 PM
Closed by commit R44:ebc918ce04bd: Port away from KTimeZone usage in KolabBase (authored by vkrause). · Explain WhyJun 11 2019, 4:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 59608

View Options

resources/kolab/pimkolab/autotests/testhelpers.h

Loading...
View Options

resources/kolab/pimkolab/kolabformatV2/kolabbase.h

Loading...
View Options

resources/kolab/pimkolab/kolabformatV2/kolabbase.cpp

Loading...