| timotheegiet | |
| scagarwal |
| GCompris: Improvements |
The following changes have been made
I haven't committed these changes in my gsoc branch as of now, I'll commit these when we finish up with review process of money activity.
| Lint Skipped |
| Unit Tests Skipped |
| src/activities/smallnumbers/resource/3/Data.qml | ||
|---|---|---|
| 28 | "up to" (in 2 words) | |
| src/core/Wordlist.qml | ||
|---|---|---|
| 108 | I would separate it in an overriden function, both code are totally unrelated | |
| src/core/Wordlist.qml | ||
|---|---|---|
| 108 | @jjazeix I created a separate function for loading wordlist from a JSON object as function overloading is not possible in javascript https://www.codeproject.com/Articles/797997/JavaScript-Does-NOT-Support-Method-Overloading-Tha . Is this okay ? | |
Good job for the activities.
There is an issue when running gletters or wordsgame:
qrc:/gcompris/src/activities/gletters/Gletters.qml:89: TypeError: Type error
There has been some improvements in the multiple_dataset branch, for example adding the ChooseLevelDialog in the activities themselves. Feel free to merge it when you think it won't be too much of a rework and you have time.
| src/activities/smallnumbers2/resource/2/Data.qml | ||
|---|---|---|
| 26 | smallnumbers2 is with dominoes | |
| 27 | be sure the diff is the same as in the code, this is missing in the repo and causes: | |
| src/core/Wordlist.qml | ||
| 108 | yes, sure | |
I didn't comment before as I saw others did and I didn't see anything more to say on that diff.
But yes, good work!
By the way while testing this diff, I noticed the difficulty icon on the activities in the menu is not following: it should be changing depending on the selected dataset levels (if several datasets selected, use the highest difficulty icon from those).
Is it something that you plan to work ?
Added comment on sub objectives.
| src/activities/smallnumbers2/resource/3/Data.qml | ||
|---|---|---|
| 30 | On a pedagogical point of view we absolutly need here an objective per level. | |
| src/activities/smallnumbers/resource/1/Data.qml | ||
|---|---|---|
| 26 | "Select a number on the dice upto ..." . Same comments for the ones below. | |
| src/activities/gletters/Gletters.qml | ||
|---|---|---|
| 89 | @scagarwal I've made the changes here https://phabricator.kde.org/D21841 | |
| src/activities/smallnumbers/resource/1/Data.qml | ||
| 26 | @amankumargupta made the changes here https://phabricator.kde.org/D21841 | |
| src/activities/smallnumbers2/resource/3/Data.qml | ||
| 30 | @echarruau I have implemented objective text per level you may have a look at it here https://phabricator.kde.org/D21841 | |