[ModifiedFileIndexer] Avoid shadowing XAttr changes by content changes
ClosedPublic

Authored by bruns on Jun 9 2019, 11:04 PM.

Details

Summary

The ModifiedFileIndexer updates the timestamps, which has the effect
the XAttr indexer will not pick up any XAttr changes later when both
happen at approximately the same time.

In case the file metadata has changed, also update everything associated
to the ctime (XAttrs, filename). This also has the nice side effect
of getting rid of a separate BasicIndexingJob run later.

Depends on D21694.

Test Plan
  1. touch testfile; sleep 10
  2. setfattr -n baloo.file.rating -v 4 ; touch testfile

After the change, balooshow testfile shows the rating.

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Jun 9 2019, 11:04 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptJun 9 2019, 11:04 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Jun 9 2019, 11:04 PM
ngraham accepted this revision.Jun 10 2019, 5:22 PM

Very nice!

This revision is now accepted and ready to land.Jun 10 2019, 5:22 PM
This revision was automatically updated to reflect the committed changes.