Differential D21700

[effects/screenshot] Remove outdated reference to KSnapshot
ClosedPublic
Actions

Authored by ghuwe on Jun 9 2019, 8:02 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:92d482b3315b: [effects/screenshot] Remove outdated reference to KSnapshot
Summary

Since KSnapshot is no longer used, I modified the text in effect_builtins.cpp to reflect that, changing it to a generic "screenshot tools".

BUG: 408407
FIXED-IN: 5.17.0

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ghuwe created this revision.Jun 9 2019, 8:02 PM
Restricted Application added a subscriber: kwin. · View Herald TranscriptJun 9 2019, 8:02 PM
ghuwe requested review of this revision.Jun 9 2019, 8:02 PM
ghuwe added a reviewer: KWin.
ghuwe edited the summary of this revision. (Show Details)Jun 9 2019, 8:18 PM
This revision is now accepted and ready to land.Jun 9 2019, 8:25 PM
ghuwe added a comment.Jun 9 2019, 8:52 PM

Ok. Since this is my first contribution, can you walk me through that?

ghuwe edited the summary of this revision. (Show Details)Jun 9 2019, 9:12 PM

Nevermind, I forgot that the commit message relates to the summary.

Did I do it right?

ghuwe added a comment.Jun 9 2019, 9:43 PM

Should I set the bug status as RESOLVED: FIXED in Bugzilla now?

filipf added a subscriber: filipf.Jun 9 2019, 10:10 PM
In D21700#476968, @ghuwe wrote:

Should I set the bug status as RESOLVED: FIXED in Bugzilla now?

It will automatically update the status once the patch is landed.

ngraham retitled this revision from Removed outdated reference to KSnapshot. to Remove outdated reference to KSnapshot.Jun 10 2019, 2:20 PM
zzag retitled this revision from Remove outdated reference to KSnapshot to [effects/screenshot] Remove outdated reference to KSnapshot.Jun 10 2019, 2:22 PM
zzag edited the summary of this revision. (Show Details)
Closed by commit R108:92d482b3315b: [effects/screenshot] Remove outdated reference to KSnapshot (authored by ghuwe, committed by ngraham). · Explain WhyJun 10 2019, 3:05 PM
This revision was automatically updated to reflect the committed changes.
ngraham added a subscriber: ngraham.Jun 10 2019, 3:09 PM

Thanks for the patch! May it be the first of many. :)

Revision Contents
Changeset List

PathPackages
Meffects/effect_builtins.cpp (2 lines)

Diff 59518

View Options

effects/effect_builtins.cpp

Loading...