Palettize Filter

Authored by surt on Jun 9 2019, 6:17 AM.


Group Reviewers
R37:c6a8935d34a8: FEATURE: Palettize Filter

Filter to match colours to selected palette and optionally apply some simple dithering.

Diff Detail

R37 Krita
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
surt requested review of this revision.Jun 9 2019, 6:17 AM
surt created this revision.
rempt added a subscriber: rempt.Jun 9 2019, 12:14 PM
rempt added inline comments.

I bet Michael isn't the author of this file :-)

surt updated this revision to Diff 59461.Jun 9 2019, 7:39 PM

Fixed copyright notice.

Removed alpha component from rtree search.

Switch to using KoResourceItemChooser instead of specialised pattern and palette choosers as preview on pattern chooser is undesirable in this case and buttons on palette chooser didn't work.

Added palette specialisation to KoResourceItemDelegate::paint so palette thumbnails wouldn't be tiled when palette image smaller than thumbnail size.

surt marked an inline comment as done.Jun 9 2019, 7:40 PM
rempt added a comment.Jun 12 2019, 3:11 PM

You don't have push access, right? If you would like that, please follow and mention me as sponsor. Apart from that, we're moving away from phabricator to

This revision was not accepted when it landed; it landed in state Needs Review.Jun 12 2019, 3:52 PM
Closed by commit R37:c6a8935d34a8: FEATURE: Palettize Filter (authored by ognarb, committed by dkazakov). · Explain Why
This revision was automatically updated to reflect the committed changes.

Hi, @surt!

Thank you for your patch, it looks and works perfectly, so I have merged it into master :)

Oups, looks like I've pasted wrong email into the commit. I'm sorry, @surt :( I should have used the line from the copyright notice... Anyway, we are moving to gitlab now (, so such mistakes shouldn't happen anymore :(