Library version has already been increased to 7.1.0 recently, and there
were no releases since then, so no need to increase it again.
Details
Details
- Reviewers
- None
- Group Reviewers
KDE Games - Commits
- R420:f0d21b91e11c: audio: Support loading of files from Qt embedded resources
tested with a modified version of KBlocks that loads sound files from its .qrc
Diff Detail
Diff Detail
- Repository
- R420 KDE Games Library
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
audio/virtualfileqt-openal.h | ||
---|---|---|
27 | Why make it a QObject? |
audio/virtualfileqt-openal.h | ||
---|---|---|
27 | oops, my idea was to destruct QFile with "this" as parent, but QFile will be destroyed anyway by default dtor. |
Comment Actions
Code makes sense, haven't tried it though.
Probably would need to add some documentation to kgsndfile saying "since version x.y.x supports reading from qrc:" or similar?
Comment Actions
- Bump version to 7.2.0, for release with KDE Applications 19.12.x
- kgsound: Mention qrc support in Doxygen comments
Comment Actions
as said, code looks reasonable to me but haven't tried it.
If you've tried and are confident that this doesn't break i'd say commit it :)