add snoretoast for win32 builds to knotifs blueprint
ClosedPublic

Authored by brute4s99 on Jun 7 2019, 11:22 PM.

Details

Summary

Add SnoreToast back-end to Win32 builds

Diff Detail

Repository
R877 Craft Blueprints for KDE
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
brute4s99 requested review of this revision.Jun 7 2019, 11:22 PM
brute4s99 created this revision.
brute4s99 edited the summary of this revision. (Show Details)Jun 7 2019, 11:23 PM
brute4s99 added reviewers: broulik, vonreth.
brute4s99 added a project: Craft.
brute4s99 retitled this revision from add snoretoast for win32 builds to add snoretoast for win32 builds to knotifs blueprint .Jun 8 2019, 10:15 PM
albertvaka accepted this revision.Jun 9 2019, 4:16 PM
albertvaka added a subscriber: albertvaka.

LGTM

This revision is now accepted and ready to land.Jun 9 2019, 4:16 PM
vonreth accepted this revision.Jun 9 2019, 4:59 PM
brute4s99 updated this revision to Diff 60012.Jun 18 2019, 9:08 AM
brute4s99 retitled this revision from add snoretoast for win32 builds to knotifs blueprint to add snoretoast for win32 builds to knotifs blueprint.
brute4s99 edited the summary of this revision. (Show Details)

rebased

should I land this?

albertvaka accepted this revision.Jul 5 2019, 1:01 PM

Sure, you've got 2 approvals (3 now).

This revision was automatically updated to reflect the committed changes.