Use full-height separators in ContentView
ClosedPublic

Authored by ngraham on Jun 7 2019, 3:42 AM.

Details

Summary

The vertical separators currently end a few pixels short of the top and bottom,
creating a sense that the window is one big thing with three loosely separated
sections. This is rather visually muddy and not consistent with KDE's other
modern apps, which all use full-height lines to separate distinct areas of the
user interface.

This patch brings the same thing to Elisa, and substantially cleans up the code
pertaining to showing and hiding the separators.

Test Plan

Album view, before:


Album view, after:

Now Playing view, before:


Now Playing view, after:

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham requested review of this revision.Jun 7 2019, 3:42 AM
ngraham created this revision.
mgallien accepted this revision.Jun 7 2019, 6:15 PM

Looks good to me

This revision is now accepted and ready to land.Jun 7 2019, 6:15 PM
This revision was automatically updated to reflect the committed changes.