Remove the custom styling from the FlatButtonWithToolTip component.
The QQC2 desktop style can handle all required features since KF 5.56
Slightly alters the appearance of the media control bar.
Details
Details
Diff Detail
Diff Detail
- Repository
- R255 Elisa
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Thanks for taking care of that. It is really appreciated.
Please see my inline comment.
src/qml/FlatButtonWithToolTip.qml | ||
---|---|---|
34–35 | You are hardcoding the size of the button and its icon in all instances made with FlatButtonWithToolTip. It would be more usable without such limitation (and could allow more widespread usage insice Elisa UI). |
src/qml/FlatButtonWithToolTip.qml | ||
---|---|---|
34–35 | Yep, working on it. I noticed binding loops after I uploaded the first version, so I quickly updated it. The plan is to replace all QQC1 buttons with this |