Remove custom styling from button component
ClosedPublic

Authored by astippich on Jun 6 2019, 6:48 PM.

Details

Summary

Remove the custom styling from the FlatButtonWithToolTip component.
The QQC2 desktop style can handle all required features since KF 5.56
Slightly alters the appearance of the media control bar.

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich requested review of this revision.Jun 6 2019, 6:48 PM
astippich created this revision.

before

after

astippich updated this revision to Diff 59293.Jun 6 2019, 8:23 PM
  • cleanup and fix binding loop

Thanks for taking care of that. It is really appreciated.
Please see my inline comment.

src/qml/FlatButtonWithToolTip.qml
34–35

You are hardcoding the size of the button and its icon in all instances made with FlatButtonWithToolTip. It would be more usable without such limitation (and could allow more widespread usage insice Elisa UI).

astippich added inline comments.Jun 6 2019, 8:53 PM
src/qml/FlatButtonWithToolTip.qml
34–35

Yep, working on it. I noticed binding loops after I uploaded the first version, so I quickly updated it. The plan is to replace all QQC1 buttons with this

astippich updated this revision to Diff 59300.Jun 6 2019, 8:59 PM
  • directly set the icon width
astippich updated this revision to Diff 59302.Jun 6 2019, 9:00 PM
  • remove unrelated change
astippich marked an inline comment as done.Jun 10 2019, 8:38 PM
ngraham accepted this revision.Jun 10 2019, 10:28 PM

LGTM!

This revision is now accepted and ready to land.Jun 10 2019, 10:28 PM
astippich updated this revision to Diff 59679.Jun 12 2019, 6:44 PM
  • rebase on master
mgallien accepted this revision.Jun 13 2019, 7:17 AM

Thanks

This revision was automatically updated to reflect the committed changes.