Differential D21633

Change Text Selection icon to edit-select-text
ClosedPublic
Actions

Authored by ndavis on Jun 6 2019, 6:43 PM.

Details

Reviewers
ngraham
Group Reviewers
VDG
Okular
Commits
R223:2c39981b21d9: Change Text Selection icon to edit-select-text
Summary

The current icon (draw-text) is semantically incorrect. This patch makes the Text Selection tool use the icons added in D21632.

BUG: 408391
FIXED-IN: 1.8.0

Test Plan

Diff Detail

Repository
R223 Okular
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ndavis created this revision.Jun 6 2019, 6:43 PM
Restricted Application added a project: Okular. · View Herald TranscriptJun 6 2019, 6:43 PM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
ndavis requested review of this revision.Jun 6 2019, 6:43 PM
ndavis edited the summary of this revision. (Show Details)Jun 6 2019, 6:45 PM
ndavis edited the summary of this revision. (Show Details)Jun 6 2019, 6:51 PM
ngraham accepted this revision.Jun 6 2019, 6:54 PM
This revision is now accepted and ready to land.Jun 6 2019, 6:54 PM
ndavis edited the test plan for this revision. (Show Details)Jun 6 2019, 6:58 PM
Closed by commit R223:2c39981b21d9: Change Text Selection icon to edit-select-text (authored by ndavis). · Explain WhyJun 6 2019, 6:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mui/pageview.cpp (2 lines)

Diff 59288

View Options

ui/pageview.cpp

Loading...