I changed the input-mouse icon so that it would look more like a real mouse. In order to keep the proper icon for the Browse tool, I have to change the icon to transform-browse.
Details
Details
- Reviewers
ngraham - Group Reviewers
Okular VDG - Commits
- R223:9310bed61621: Change Browse icon back to the hand shape
Diff Detail
Diff Detail
- Repository
- R223 Okular
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
wow Not even one minute to review things
I don't particularly like this, input-mouse is an icon that exists in most icon themes
extra/adwaita-icon-theme
extra/breeze-icons
extra/efl
extra/gnome-icon-theme
extra/gnome-icon-theme-symbolic
extra/gnome-themes-extra
extra/oxygen-icons
extra/oxygen-icons-svg
extra/qt5-doc
extra/xf86-input-mouse
extra/xfce4-power-manager
community/arc-icon-theme
community/elementary-icon-theme
community/faba-icon-theme
community/faenza-icon-theme
community/lxinput
community/lxinput-gtk3
community/mate-icon-theme
community/mate-icon-theme-faenza
community/mate-themes
community/moka-icon-theme
community/papirus-icon-theme
transform-browse exists only in breeze-icons
but 🤷♂️ i guess
Comment Actions
Sorry, I'll wait longer in the future, but input-mouse is still wrong. This simply doesn't mean the same thing as "grabber" or "browse": https://raw.githubusercontent.com/GNOME/adwaita-icon-theme/master/Adwaita/22x22/legacy/input-mouse.png
However, if you feel this commit should be reverted, my feelings won't be hurt. If you know of another common icon that works better than input-mouse, perhaps we can use that instead?
Comment Actions
@aacid transform-move is slightly less correct, but it's in Oxygen and Papirus (not Adwaita). Would you prefer if that icon was used?
Comment Actions
I know, but at least is an icon that exists.
On the other hand thanks to my fixes to kicontheme >= 5.50 and Qt >= 5.12 if the icon doesn't exist in the user icon theme it'll try to fallback to breeze, will look ultra weird but at least won't be a button without text nor icon
i guess it can stay