Right now, the Task Manager's popup has various buttons in it that do not look or
feel like buttons because they are implemented as a MouseArea with an Icon inside.
This patch makes them feel like standard buttons uses elsewhere by implementing
them using ToolButtons instead.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
It is also makes it consistent with the notification popup. Let me give it a quick spin.
+1 buttons should be buttons unless there's really strong designer reasons such as in the login screen etc. I'm also enjoying this a lot more than than just having icons.
BTW when talking about consistency, do we also apply this change to the media player applet?
EDIT: disregard last comment, I was looking at 5.15.
| applets/taskmanager/package/contents/ui/ToolTipInstance.qml | ||
|---|---|---|
| 336 | Do we also have the issue here that the tool button will grow in size but not the icon inside it? Seems OK when I bump up the scaling. | |
| applets/taskmanager/package/contents/ui/ToolTipInstance.qml | ||
|---|---|---|
| 336 | Nah, the out-of-the-box behavior is fine, that comment is just there to indicate what needs to happen before we can make the Play button bigger, as it is without this patch. | |
+1
We might need to add some padding so the button frame doesn't overlay content on the background
That's a pre-existing bug only visible when the pop-up isn't displaying a media preview. We can fix that in another revision.
As far as I can tell the button is actually within it's own frame/rectangle, it's Elisa's icon that drops too low and then sits behind the frame/rectangle.
Looks good. Perhaps now that we can have proper tooltips for the buttons we should add some?