[Task manager] Use Windows-style middle-click behaviors for entries and thumbnails
ClosedPublic

Authored by ngraham on Thu, Jun 6, 4:39 PM.

Details

Summary

The Windows 10 Task Manager equivalent opens a new instance when middle-clicking an
open Task, and when middle-clicking on a thumbnail in the pop-up, that task is closed.

These are some nice shortcuts. This patch implements the same behaviors for our Task
Manager.

Test Plan
  1. Delete ~/.config/plasma-org.kde.plasma.desktop-appletsrc and restart plasmashell
  2. Open an app
  3. Middle-click on the app's Task -> see that a new instance is created
  4. Keep middle-clicking on the app's Task until it becomes grouped
  5. Move the mouse over the grouped task
  6. Middle-click on a thumbnail in the pop-up -> see how that instance is closed

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Thu, Jun 6, 4:39 PM
Restricted Application added a project: Plasma. · View Herald TranscriptThu, Jun 6, 4:39 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Thu, Jun 6, 4:39 PM
ndavis added a subscriber: ndavis.Thu, Jun 6, 4:57 PM

Is the current default group/ungroup or is the current default none? If the former is true, why is this better? If the latter, then +1 because it's useful.

The current default is None.

ndavis accepted this revision.Thu, Jun 6, 5:06 PM
This revision is now accepted and ready to land.Thu, Jun 6, 5:06 PM
ngraham retitled this revision from Use Windows-style middle-click behaviors for Task Manager entries and thumbnails to [Task manager] Use Windows-style middle-click behaviors for entries and thumbnails.EditedThu, Jun 6, 5:07 PM

Thanks. I had a feeling that the default settings change would not be too controversial but I won't land this until I get at least one positive review from a Plasma person, since the new middle-click-to-close behavior for popup thumbnails is destructive and could be controversial. I didn't add an option to disable it because of the desire to not add new options for everything, but I'd like to see it discussed before I land the patch.

hein accepted this revision.Thu, Jun 6, 6:11 PM
This revision was automatically updated to reflect the committed changes.