Handle action authorization inside helper
Needs ReviewPublic

Authored by shubham on Jun 6 2019, 10:02 AM.

Details

Summary

Depends upon D21564

Handle action authorization inside ExternalCommand helper

Diff Detail

Repository
R16 KPMCore
Branch
integrate_into_helper
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12507
Build 12525: arc lint + arc unit
shubham requested review of this revision.Jun 6 2019, 10:02 AM
shubham created this revision.
shubham updated this revision to Diff 59251.Jun 6 2019, 10:04 AM

diff relative to D21564

cjlcarvalho added inline comments.Jun 6 2019, 8:53 PM
src/util/dbus.service
4

Why foohelper?

src/util/externalcommandhelper.cpp
284

How is this method going to be called?

shubham updated this revision to Diff 59312.Jun 7 2019, 4:21 AM

Remove FindPolkitQt1.cmake

shubham added inline comments.Jun 7 2019, 2:21 PM
src/util/externalcommandhelper.cpp
284

I may cal this from startHelper(), I am not sure. What are your suggestions?

I think startHelper() is much better.