Handle action authorization inside helper
AbandonedPublic
Actions

Authored by shubham on Jun 6 2019, 10:02 AM.

Details

Reviewers

stikonas
cjlcarvalho

Summary

Depends upon D21564

Handle action authorization inside ExternalCommand helper

Repository

R16 KPMCore

Branch

integrate_into_helper

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 12470
Build 12488: arc lint + arc unit

shubham requested review of this revision.Jun 6 2019, 10:02 AM

shubham created this revision.

diff relative to D21564

src/util/dbus.service
4	Why foohelper?
src/util/externalcommandhelper.cpp
284	How is this method going to be called?

Remove FindPolkitQt1.cmake

src/util/externalcommandhelper.cpp
284	I may cal this from startHelper(), I am not sure. What are your suggestions?

Rebase

I think startHelper() is much better.

		Path
M		CMakeLists.txt (4 lines)
A	M	cmake/modules/FindPolkitQt-1.cmake (36 lines)
M		src/CMakeLists.txt (1 line)
M		src/util/CMakeLists.txt (3 lines)
A	M	src/util/dbus.service (4 lines)
A	M	src/util/externalcommand_authagent.h (73 lines)
A	M	src/util/externalcommand_authagent.cpp (132 lines)
M		src/util/externalcommandhelper.h (10 lines)
M		src/util/externalcommandhelper.cpp (25 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	59250	f481109		Jun 6 2019, 10:02 AM	★	★
Diff 2	59251	835923c	diff relative to D21564	Jun 6 2019, 10:04 AM	★	★
Diff 3	59312	835923c	Remove FindPolkitQt1.cmake	Jun 7 2019, 4:21 AM	★	★
Diff 4	59347	835923c	Rebase	Jun 7 2019, 2:25 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
c36709beb875	33c378ca9e0e	835923c36c86	Shubham Jangra	Handle action authorization inside helper	Jun 6 2019, 10:01 AM
835923c36c86	b379ac39d8f1	f481109417dd	Shubham Jangra	[WIP]: Implement Authentication Agent/Listener (Show More…)	Jun 6 2019, 9:29 AM