Differential D21615

Context - aware shortcuts for NSIS based installers
AbandonedPublic
Actions

Authored by brute4s99 on Jun 5 2019, 10:04 PM.

Details

Reviewers
vonreth

Diff Detail

Repository
R138 Craft
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12459
Build 12477: arc lint + arc unit
brute4s99 requested review of this revision.Jun 5 2019, 10:04 PM
brute4s99 created this revision.
vonreth added inline comments.Jun 6 2019, 12:58 PM
bin/Packager/Nsis/NullsoftInstaller.nsi
165

Hm do we need to touch SetShellVarContext at all?
I don't think we need it now that we have use the MultiUser stuff, does it work without this call?

brute4s99 abandoned this revision.Jun 7 2019, 11:13 PM

closing this diff wrt https://cgit.kde.org/craft.git/commit/?id=ca58925512c2d553576259bde8f390e518c12384

bin/Packager/Nsis/NullsoftInstaller.nsi
165

Without this change, the shortcuts are installed in the global $SMPROGRAMS and thus does not respect the "install only for me" option during installation.
I haven't tried without the call, I can try it some time today :)

Revision Contents
Changeset List

Diff 59234

View Options

bin/Packager/Nsis/NullsoftInstaller.nsi

Loading...