Differential D21614

[sddm-theme] Fix fontsize of virtual keyboard ToolButton
ClosedPublic
Actions

Authored by filipf on Jun 5 2019, 9:13 PM.

Details

Reviewers
hein
veqz
ngraham
Group Reviewers
VDG
Commits
R120:928201c550eb: [sddm-theme] Fix fontsize of virtual keyboard ToolButton
R120:58b1c844e821: Merge remote-tracking branch 'origin/Plasma/5.16'
Summary

When we updated the fonts in the sddm-theme, we bumped the default size from 9pt to 10pt. We missed adding the relevant code to the virtual keyboard button so it remained 9pt. This patch brings it up to 10pt.

Test Plan

Before:

After:

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.Jun 5 2019, 9:13 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 5 2019, 9:13 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Jun 5 2019, 9:13 PM
filipf edited the test plan for this revision. (Show Details)Jun 5 2019, 9:14 PM
filipf added a reviewer: VDG.Jun 5 2019, 9:16 PM
hein accepted this revision.Jun 5 2019, 9:17 PM
This revision is now accepted and ready to land.Jun 5 2019, 9:17 PM
veqz accepted this revision.Jun 5 2019, 9:20 PM
veqz added a subscriber: veqz.

Looks better to me.

Though wouldn't it be even better if it was even a point larger?

ngraham accepted this revision.Jun 5 2019, 9:20 PM
ngraham added a subscriber: ngraham.

Whoops!

ngraham added a comment.Jun 5 2019, 9:21 PM
In D21614#474950, @veqz wrote:

Looks better to me.

Though wouldn't it be even better if it was even a point larger?

In fact I think most of our text looks better at 11 pt font, but that's a somewhat unpopular opinion. :)

Closed by commit R120:928201c550eb: [sddm-theme] Fix fontsize of virtual keyboard ToolButton (authored by filipf). · Explain WhyJun 5 2019, 9:23 PM
This revision was automatically updated to reflect the committed changes.
filipf added a comment.Jun 5 2019, 9:26 PM

Thanks for the quick review everyone :)

In D21614#474950, @veqz wrote:

Looks better to me.

Though wouldn't it be even better if it was even a point larger?

They way we set it up now is that there is a hierarchy among font sizes and these buttons are the bottom had low priority. But 11pt would also be legitimate. From 5.17 the user should be able to have their own font size so we'll remove all this hardcoding.

Revision Contents
Changeset List

PathPackages
Msddm-theme/Main.qml (1 line)

Diff 59230

View Options

sddm-theme/Main.qml

Loading...