Differential D21612

Add Un.Sections to NSIS Template
ClosedPublic
Actions

Authored by brute4s99 on Jun 5 2019, 7:06 PM.

Details

Reviewers
vonreth
Commits
R138:2eaf4689503a: Add Un.Sections to NSIS Template

Diff Detail

Repository
R138 Craft
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12449
Build 12467: arc lint + arc unit
brute4s99 requested review of this revision.Jun 5 2019, 7:06 PM
brute4s99 created this revision.
vonreth added inline comments.Jun 5 2019, 7:20 PM
bin/Packager/Nsis/NullsoftInstaller.nsi
93

I wouldn't offer uninstall of components, uninstall is always uninstall everything? So remove un_section_page?

brute4s99 updated this revision to Diff 59219.Jun 5 2019, 7:36 PM

removed components page for uninstaller

brute4s99 updated this revision to Diff 59220.Jun 5 2019, 7:42 PM
brute4s99 marked an inline comment as done.
vonreth accepted this revision.Jun 5 2019, 8:40 PM

looks good, if the section is does end up in the right place this looks perfect :)

This revision is now accepted and ready to land.Jun 5 2019, 8:40 PM
Closed by commit R138:2eaf4689503a: Add Un.Sections to NSIS Template (authored by brute4s99). · Explain WhyJun 5 2019, 10:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 59219

View Options

bin/Packager/Nsis/NullsoftInstaller.nsi

Loading...
View Options

bin/Packager/NullsoftInstallerPackager.py

Loading...