Is there any accessibility dedicated review group ?

Having recently read this https://raphaelhertzog.com/2011/06/24/people-behin-debian-sam-hartman-kerberos-package-maintainer/ got me motivated to improve Elisa with regard to screen reader accessibility.

There's Plasma Accessibility which is maybe good enough? Might be worth it for us to create a more generic one though.

Blind people rarely click. Some a10y software has a way to trigger actions directly.

Accessible.onPressAction: onClicked

Would probably suffice.

Woe :) cool this looks very promising.
you can just add Plasma Accessibility i will try to review then as soon as i find time :)
thanks for care about that :).

as you already planned changes i will wait for an test til those are done.
an small thing we need to take care, is that also the current active element gets the focus. screenreaders react to the "focus:true" property to present the current active element.
in Kickoff this is an issue. I will test this here next couple of days.
Thanks!!! :).

In D21608#474936, @chempfling wrote:

an small thing we need to take care, is that also the current active element gets the focus. screenreaders react to the "focus:true" property to present the current active element.
in Kickoff this is an issue. I will test this here next couple of days.
Thanks!!! :).

In fact that was just improved/fixed yesterday in D21081!

In D21608#474912, @davidedmundson wrote:

Blind people rarely click. Some a10y software has a way to trigger actions directly.

Accessible.onPressAction: onClicked

Would probably suffice.

Does this mean that every button with onClicked ideally also needs Accessible.onPressAction: onClicked too?

In D21608#474960, @ngraham wrote:

In D21608#474936, @chempfling wrote:

an small thing we need to take care, is that also the current active element gets the focus. screenreaders react to the "focus:true" property to present the current active element.
in Kickoff this is an issue. I will test this here next couple of days.
Thanks!!! :).

In fact that was just improved/fixed yesterday in D21081!

Ahh sweet:). Thanks! Yea those pseudo rectangles are used very often without proper focus handling. Thats why i told :).

In D21608#474912, @davidedmundson wrote:

Blind people rarely click. Some a10y software has a way to trigger actions directly.

Accessible.onPressAction: onClicked

Would probably suffice.

Does this mean that every button with onClicked ideally also needs Accessible.onPressAction: onClicked too?

For Press this is not needed. I dont know where is the difference between press and click as the documentation tells the same.
https://doc.qt.io/qt-5/qml-qtquick-controls2-abstractbutton.html#pressed-signal
https://doc.qt.io/qt-5/qml-qtquick-controls2-abstractbutton.html#clicked-signal

I would feel better if pressed is used for buttons. As klick sounds more like mouse is required also the documentation says different.

i think you don't need the
"Accessible.onPressAction"
stuff when you use

• onPressed

insteed of :

• onClicked

i never used it with onPressed and it worked always just fine :).
but it should work too. just curious for my own interest, is there a reason why always onClicked is used instead of onPressed? As for me it sounds more natural to press an button. does anyone know the exact difference? as i can read from the QT docu its the same? is it?

In D21608#475528, @chempfling wrote:

i think you don't need the
"Accessible.onPressAction"
stuff when you use

• onPressed insteed of :
• onClicked
  
  i never used it with onPressed and it worked always just fine :). but it should work too. just curious for my own interest, is there a reason why always onClicked is used instead of onPressed? As for me it sounds more natural to press an button. does anyone know the exact difference? as i can read from the QT docu its the same? is it?

When reading Qt documentation, I understand it as specifically activated by screen readers. This is also what @davidedmundson recommended in its review.

In D21608#475035, @chempfling wrote:

[...]

In D21608#474912, @davidedmundson wrote:

Blind people rarely click. Some a10y software has a way to trigger actions directly.

Accessible.onPressAction: onClicked

Would probably suffice.

Does this mean that every button with onClicked ideally also needs Accessible.onPressAction: onClicked too?

For Press this is not needed. I dont know where is the difference between press and click as the documentation tells the same.
https://doc.qt.io/qt-5/qml-qtquick-controls2-abstractbutton.html#pressed-signal
https://doc.qt.io/qt-5/qml-qtquick-controls2-abstractbutton.html#clicked-signal

I would feel better if pressed is used for buttons. As klick sounds more like mouse is required also the documentation says different.

As far as I know (and a confirmation by reading Qt source), pressed and clicked should probably be different. I remember having read (not remembering the reference at the moment) that "clicked" is the action of pressing and un pressing the button.

Should I make further modifications or land the current patch ?

In D21608#475980, @mgallien wrote:

As far as I know (and a confirmation by reading Qt source), pressed and clicked should probably be different. I remember having read (not remembering the reference at the moment) that "clicked" is the action of pressing and un pressing the button.

Yes that's correct, from this stackexchange answer:

• Pressed: event is generated when you push down the mouse button
• Released: event is generated when you release the mouse button (which has been pressed down before)
• Clicked: event is generated when a mouse button Pressed & Released.

By the way: Thanks for care about accessibility! this is awsome :).

In D21608#478700, @chempfling wrote:

By the way: Thanks for care about accessibility! this is awsome :).

Thanks a lot for your comment.
I consider that proper accessibility is one of the thing that is/was lacking in Elisa and should be taken for granted.

Thanks a lot for your comment.
I consider that proper accessibility is one of the thing that is/was lacking in Elisa and should be taken for granted.

you are completly right.
A11y is important in enterprise sector. thats why i created T11074 its very needed and its already too long out of scope