Differential D21604

Fix building with Qt 5.13
AbandonedPublic
Actions

Authored by carewolf on Jun 5 2019, 2:57 PM.

Details

Reviewers
bruns
ngraham

Diff Detail

Repository
R293 Baloo
Branch
fix-build (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12433
Build 12451: arc lint + arc unit
carewolf created this revision.Jun 5 2019, 2:57 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptJun 5 2019, 2:57 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
carewolf requested review of this revision.Jun 5 2019, 2:57 PM
alexeymin added a subscriber: alexeymin.Jun 5 2019, 3:08 PM
alexeymin added inline comments.
src/file/regexpcache.cpp
81

can probably just be QString suffixMatch(QLatin1String("^.*\\.(")); then, without =

carewolf added inline comments.Jun 5 2019, 3:39 PM
src/file/regexpcache.cpp
81

Sure, but it hardly matters, copy-elision will make the statements equivalent.

bruns requested changes to this revision.Jun 5 2019, 3:42 PM

This lacks a proper commit message

This revision now requires changes to proceed.Jun 5 2019, 3:42 PM
carewolf abandoned this revision.Mar 13 2020, 3:28 PM

Done independently

Revision Contents
Changeset List

PathPackages
Msrc/file/regexpcache.cpp (2 lines)

Diff 59200

View Options

src/file/regexpcache.cpp

Loading...