[System Tray] Round item size to icon size
ClosedPublic

Authored by broulik on Jul 14 2016, 9:52 AM.

Details

Summary

This should fix the icons growing so large that there's hardly any padding around them so they would overlap the indicator strip. It also makes the icon size consistent with other icons on the panel.

Test Plan

I thought that the icons had to have the same size as the container for Fitt's law but turns out the mouse area that actually triggers the item always spans the full size so it still works when you just click the corner of the screen.

Sorry all for that terrible visual regression :/

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 5145.Jul 14 2016, 9:52 AM
broulik retitled this revision from to [System Tray] Round item size to icon size.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptJul 14 2016, 9:52 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Jul 14 2016, 11:54 AM
mart added a reviewer: mart.
mart added a subscriber: mart.

would have to be only for 5.7 branch tough

This revision is now accepted and ready to land.Jul 14 2016, 11:54 AM
hein added a subscriber: hein.Jul 14 2016, 12:02 PM

Tray icons still larger than conventional panel icons, here comparing Volume Control in tray vs. standalone widget:

So, should we get this into 5.7.2? It's definitely an improvement to the 5.7.1 situation, especially for the blurry xembed icons.

As for Eike's issue, I have really no clue why that happens, I looked into CompactApplet and everywhere and don't see any additional margins that we don't have in System Tray :/

mart added a comment.Jul 18 2016, 8:48 AM

yes, definitely in 5.7.2

This revision was automatically updated to reflect the committed changes.