Differential D21594

Allow media controls and tabs runner in incognito mode for Firefox 67
ClosedPublic
Actions

Authored by broulik on Jun 5 2019, 9:05 AM.

Details

Reviewers
fvogt
Group Reviewers
Plasma
Commits
R856:e7c353c7f437: Allow media controls and tabs runner in incognito mode for Firefox 67
Summary

In Firefox 67 it gained an option to disable extensions in incognito mode similar to how Chrome does it.
Enable media controls and tabs runner if the user enabled the extension in incognito mode.

Test Plan
  • Allowed p-b-i to run in incognito mode in Firefox, started a video in incognito, could control it.
  • could also find that incognito tab
  • Chrome still works fine

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jun 5 2019, 9:05 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 5 2019, 9:05 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jun 5 2019, 9:05 AM
fvogt accepted this revision.Jun 5 2019, 9:15 AM
This revision is now accepted and ready to land.Jun 5 2019, 9:15 AM
Closed by commit R856:e7c353c7f437: Allow media controls and tabs runner in incognito mode for Firefox 67 (authored by broulik). · Explain WhyJun 5 2019, 9:20 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mextension/extension.js (11 lines)

Diff 59179

View Options

extension/extension.js

Loading...