Added audio capture channels & sample rate selection
ClosedPublic

Authored by jeanlemotan on Jun 5 2019, 8:20 AM.

Details

Reviewers
mardelle
Group Reviewers
VDG
Kdenlive
Summary

I added the ability to select the sample rate and channel selection for audio capture.
There are changes to settings, UI (the capture settings dialog) and the capture code - to use the settings.

Diff Detail

Repository
R158 Kdenlive
Lint
Lint Skipped
Unit
Unit Tests Skipped
jeanlemotan requested review of this revision.Jun 5 2019, 8:20 AM
jeanlemotan created this revision.
mardelle accepted this revision.Jun 7 2019, 9:14 AM
mardelle added a subscriber: mardelle.

Thanks a lot for your work, looks perfectly fine. We have now switched to gitlab (https://invent.kde.org/kde/kdenlive ) which provides an easier merge request workflow and author attribution.
If you want I can merge your commit mentionning your name, but if you want full attibution, it's easier for us if you make a fork on invent.kde.org and create a merge request. Welcome!

This revision is now accepted and ready to land.Jun 7 2019, 9:14 AM

Thanks a lot for your work, looks perfectly fine. We have now switched to gitlab (https://invent.kde.org/kde/kdenlive ) which provides an easier merge request workflow and author attribution.
If you want I can merge your commit mentionning your name, but if you want full attibution, it's easier for us if you make a fork on invent.kde.org and create a merge request. Welcome!

I'll create a merge request for gitlab over the weekend.

Not sure if you saw it or not - but I added a warning if there are no devices registered: "Make sure you have audio plugins installed on your system"
It shows right under the Devices combobox.
I forgot to mention it in the change list because I honestly forgot I added this. It should help users that see no devices listed and wonder that's going on. Happened to me twice.

I just created the MR: https://invent.kde.org/kde/kdenlive/merge_requests/45
Let me know if there's something missing.
As far as I am concerned, this can be closed and we can continue on gitlab.

You need to "abandon" it yourself using the Add Action... menu.

mardelle closed this revision.Jul 5 2019, 5:48 AM