Fix rubber band not going away after right-click
ClosedPublic

Authored by jacksonmcneill on Jun 5 2019, 2:29 AM.

Details

Summary

Fix rubber band not going away after right-click in the folder view

Test Plan

Hold left click
Drag to make rubber band
Right click

Diff Detail

Repository
R318 Dolphin
Branch
rubberband-fix (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12417
Build 12435: arc lint + arc unit
jacksonmcneill created this revision.Jun 5 2019, 2:29 AM
Restricted Application added a project: Dolphin. · View Herald TranscriptJun 5 2019, 2:29 AM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
jacksonmcneill requested review of this revision.Jun 5 2019, 2:29 AM
ngraham added a subscriber: ngraham.
ngraham added inline comments.
src/kitemviews/kitemlistcontroller.cpp
538

Unrelated whitespace change

  • Whitespace changes
  • Remove accidental newline
jacksonmcneill marked an inline comment as done.Jun 9 2019, 8:23 PM
ngraham accepted this revision.Jun 10 2019, 8:38 PM
ngraham added a reviewer: elvisangelaccio.
ngraham added a subscriber: elvisangelaccio.

Works great, thanks!

@elvisangelaccio?

This revision is now accepted and ready to land.Jun 10 2019, 8:38 PM
elvisangelaccio requested changes to this revision.Jun 16 2019, 11:25 AM
elvisangelaccio added inline comments.
src/kitemviews/kitemlistcontroller.cpp
604–606

Please wrap this code within if (rubberBand->isActive()) { ... }

This revision now requires changes to proceed.Jun 16 2019, 11:25 AM

Wrap rubber band code in if (rubberBand->isActive)

jacksonmcneill marked an inline comment as done.Jul 8 2019, 9:57 PM
ngraham added inline comments.Jul 9 2019, 12:22 AM
src/kitemviews/kitemlistcontroller.cpp
605

KDE coding style: Open braces go on the same line as the if statement

Fix code style

jacksonmcneill marked an inline comment as done.Jul 16 2019, 2:57 AM

Thanks, I missed that

ngraham accepted this revision.Jul 16 2019, 3:03 AM
elvisangelaccio accepted this revision.Jul 17 2019, 7:39 PM
This revision is now accepted and ready to land.Jul 17 2019, 7:39 PM
This revision was automatically updated to reflect the committed changes.