Differential D2159

[src/server] Verify that surface has a resource before sending pointer enter
ClosedPublic
Actions

Authored by graesslin on Jul 14 2016, 9:47 AM.

Details

Reviewers
sebas
Group Reviewers
Plasma on Wayland
Commits
R127:92036ba9169d: [src/server] Verify that surface has a resource before sending pointer enter
Summary

If we try to send a pointer enter on a null resource of a Surface
(e.g. after unbound) we hit a marshalling error:
error marshalling arguments for enter (signature uoff): null value passed for arg 1

The added test case hits this error without the change and passes
cleanly with the change.

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 5144.Jul 14 2016, 9:47 AM
graesslin retitled this revision from to [src/server] Verify that surface has a resource before sending pointer enter.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added a reviewer: Plasma on Wayland.
Restricted Application added a project: Plasma on Wayland. · View Herald TranscriptJul 14 2016, 9:47 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sebas accepted this revision.Jul 14 2016, 11:53 AM
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.Jul 14 2016, 11:53 AM
Closed by commit R127:92036ba9169d: [src/server] Verify that surface has a resource before sending pointer enter (authored by graesslin). · Explain WhyJul 14 2016, 12:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 5157

View Options

autotests/client/test_wayland_seat.cpp

Loading...
View Options

src/server/pointer_interface.cpp

Loading...