Differential D21580

Grepview - Introduce a new intermediate level corresponding to lines
ClosedPublic
Actions

Authored by davidre on Jun 4 2019, 3:01 PM.

Details

Reviewers
apol
Group Reviewers
KDevelop
Commits
R32:75a222b64e26: Grepview - Introduce a new intermediate level corresponding to lines
Summary

Add items that correspond to whole lines which is useful if a line contains multiple matches.

Test Plan


Tests pass

Diff Detail

Repository
R32 KDevelop
Branch
grepViewLines
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12396
Build 12414: arc lint + arc unit
davidre created this revision.Jun 4 2019, 3:01 PM
Restricted Application added a project: KDevelop. · View Herald TranscriptJun 4 2019, 3:01 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
davidre requested review of this revision.Jun 4 2019, 3:01 PM
davidre edited the test plan for this revision. (Show Details)Jun 4 2019, 3:02 PM
davidre updated this revision to Diff 59134.Jun 4 2019, 3:07 PM

Missing idx_line

apol accepted this revision.Jun 12 2019, 2:07 PM
This revision is now accepted and ready to land.Jun 12 2019, 2:07 PM
davidre closed this revision.Jun 12 2019, 2:53 PM
kossebau added a subscriber: kossebau.Jun 17 2019, 2:11 PM

This sadly seems to have broken navigating with the "Next item"/"Previous item" actions for me. Please give this a look.

davidre added a comment.Jun 17 2019, 2:59 PM
In D21580#481264, @kossebau wrote:

This sadly seems to have broken navigating with the "Next item"/"Previous item" actions for me. Please give this a look.

Could you please elaborate? Next/Previous item works for me. Is it totally broken or only in some specific cases?

Revision Contents
Changeset List

Diff 59134

View Options

plugins/grepview/grepoutputdelegate.cpp

Loading...
View Options

plugins/grepview/grepoutputmodel.h

Loading...
View Options

plugins/grepview/grepoutputmodel.cpp

Loading...