In case a file is not in the index, either because it is new, or as it
should not be indexed, there is no need to retrieve the timestamps from
the file (it will be different).
Details
Details
- Reviewers
ngraham astippich poboiko - Group Reviewers
Baloo - Commits
- R293:ecc28c314e1a: [UnindexedFileIndexer] Skip filetime checks for new files
Diff Detail
Diff Detail
- Repository
- R293 Baloo
- Branch
- submit_unindexed
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 12391 Build 12409: arc lint + arc unit
Comment Actions
I didn't know QFileInfo fetches information on demand (and caches it). That is the reason for this change, right?
I think it would be nice to elaborate on that in summary, or maybe as a brief comment in the code.
src/file/unindexedfileiterator.cpp | ||
---|---|---|
109 | Why do we need it here? |
Comment Actions
As far as I can see, the time is actually spent in converting from statbuf to QDateTime, and the underlying data is filled in when QFileInfo is instantiated in the QDirIterator.
Although, where the time is spent is irrelevant - the timestamps are of no use when the file is new.
src/file/unindexedfileiterator.cpp | ||
---|---|---|
109 | leftover |