Differential D21576

[UnindexedFileIndexer] Do not try to add nonexistant file to index
ClosedPublic
Actions

Authored by bruns on Jun 4 2019, 2:08 PM.

Details

Reviewers
ngraham
astippich
poboiko
Group Reviewers
Baloo
Commits
R293:7ab4cc5611a3: [UnindexedFileIndexer] Do not try to add nonexistant file to index
Summary

A file may be deleted after it has been picked up by the iterator,
causing the fileId to be 0. This is not an error, remove the Q_ASSERT
and silently skip the file.

Diff Detail

Repository
R293 Baloo
Branch
submit_unindexed
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12390
Build 12408: arc lint + arc unit
bruns created this revision.Jun 4 2019, 2:08 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptJun 4 2019, 2:08 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Jun 4 2019, 2:08 PM
poboiko accepted this revision.Jun 4 2019, 5:06 PM
This revision is now accepted and ready to land.Jun 4 2019, 5:06 PM
ngraham accepted this revision.Jun 4 2019, 5:31 PM

Buh!

Closed by commit R293:7ab4cc5611a3: [UnindexedFileIndexer] Do not try to add nonexistant file to index (authored by bruns). · Explain WhyJun 4 2019, 5:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/file/unindexedfileiterator.cpp (4 lines)

Diff 59127

View Options

src/file/unindexedfileiterator.cpp

Loading...