Improve label for Disk Monitor widget

Authored by ngraham on Jun 3 2019, 7:11 PM.


Group Reviewers

Currently it uses up and down arrows, which do not really map to "read" and "write".

This patch makes the up/down labels overridable properties, and makes the Disk Monitor
widget use the new properties to set clearer labels.

Test Plan

(text contrast is not great in this screenshot because my VM isn't blurring the translucent
background. Also, that's a separate issue for another patch)

Diff Detail

R120 Plasma Workspace
better-disk-monitor-label (branched from master)
No Linters Available
No Unit Test Coverage
Build Status
Buildable 12370
Build 12388: arc lint + arc unit
ngraham created this revision.Jun 3 2019, 7:11 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 3 2019, 7:11 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Jun 3 2019, 7:11 PM
sitter edited the summary of this revision. (Show Details)Jun 11 2019, 12:38 PM

In the panel, it's not ideal for sure:

However this is a pre-existing bug; all of the monitors have a sub-optimal UI for displaying the legend when in a horizontal format.

abetts added a subscriber: abetts.Jun 11 2019, 2:35 PM

+1 on visuals

sitter requested changes to this revision.Jun 11 2019, 2:57 PM
sitter added a subscriber: sitter.

The panel now is really bad though because the text uses more space than the arrows and the size is probably not accounting for that:

before the spacing was largely garbage

but at least not horrendously broken

The contrast between 'Read' and the blue graph also gets pretty bad when the graph goes up enough, which is hard to test on an SSD but I definitely see a problem there. Also at least on my shoddy screen the green of the 'Write' is super horrible against the grey of the panel.

So, I think that minimum size calculation needs adjustments somewhere so the graphs on the panel even have a chance of fitting the now longer labels. And quite possibly the font itself needs shadows turned on so it gets greater contrast with the graph, although admittedly I don't know if that will help.

This revision now requires changes to proceed.Jun 11 2019, 2:57 PM
ngraham abandoned this revision.Mar 16 2020, 3:51 PM