manually quit kauth's mainloop
ClosedPublic

Authored by sitter on Jun 3 2019, 12:52 PM.

Details

Summary

kauth helpers have a qcoreapplication started which auto-terminates after
10 seconds of idle time. this would be an added time out on top of our
life time management that is not necessary. to prevent this additional
delay simply quit the qapplication directly.

manually quit kauth's mainloop

kauth helpers have a qcoreapplication started which auto-terminates after
10 seconds of idle time. this would be an added time out on top of our
life time management that is not necessary. to prevent this additional
delay simply quit the qapplication directly.

this makes helper termination almost instantaneous even when the dbus
client disappears due to crash or SIGINT, and largely removes the
need to call stopHelper altogether.

BUG: 408245

Test Plan

both partitionmanager and calamares instantly quit the helper no matter how the client process gets terminated

other than that everything seems to work as before

Diff Detail

Repository
R16 KPMCore
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter requested review of this revision.Jun 3 2019, 12:52 PM
sitter created this revision.
sitter edited the test plan for this revision. (Show Details)Jun 3 2019, 1:00 PM
sitter added a reviewer: stikonas.
sitter added a comment.Jun 3 2019, 1:06 PM

[15:01] <stikonas> sitter: ok, looks good. Push it

This revision was not accepted when it landed; it landed in state Needs Review.Jun 3 2019, 1:09 PM
This revision was automatically updated to reflect the committed changes.