Allow setting fullscreen via MPRIS
ClosedPublic

Authored by broulik on Jun 3 2019, 7:15 AM.

Details

Summary

This implements CanSetFullscreen to return true when it's a video and lets the Fullscreen property reflect and change the fullscreen state of the player.

BUG: 408059

Test Plan

YouTube sets the entire website as fullscreen and gets confused when just fullscreening the player but it works fine in e.g. Vimeo.
If the video autostarted it refuses to fullscreen it as there hasn't been any user interaction, otherwise works fine.

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jun 3 2019, 7:15 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 3 2019, 7:15 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jun 3 2019, 7:15 AM
broulik added a reviewer: nicolasfella.
fvogt edited the test plan for this revision. (Show Details)Jun 6 2019, 5:09 PM
fvogt accepted this revision.Jun 6 2019, 5:15 PM
This revision is now accepted and ready to land.Jun 6 2019, 5:15 PM
This revision was automatically updated to reflect the committed changes.