Differential D21547

Tighter match own service when trying to find suitable window to open path in.
ClosedPublic
Actions

Authored by thomasp on Jun 2 2019, 6:43 PM.

Details

Reviewers
feverfew
elvisangelaccio
Group Reviewers
Dolphin
Commits
R318:853a95b6d5d2: Tighter match own service when trying to find suitable window to open path in.
Summary

Current implementation matches org.kde.dolphin-.*PID while trying to exclude itself from the list of running instances.
With this fix applied only org.kde.dolphin-PID is matched.

This implements my late change request D16648#inline-121014

Test Plan

Open dolphin twice. Observe only one window.

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
thomasp created this revision.Jun 2 2019, 6:43 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptJun 2 2019, 6:43 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
thomasp requested review of this revision.Jun 2 2019, 6:43 PM
thomasp edited the summary of this revision. (Show Details)Jun 2 2019, 7:15 PM
elvisangelaccio accepted this revision.Jun 2 2019, 9:51 PM
elvisangelaccio added a subscriber: elvisangelaccio.

Makes sense, thanks!

This revision is now accepted and ready to land.Jun 2 2019, 9:51 PM
thomasp added a comment.Jun 2 2019, 10:49 PM

Can you please commit on my behalf?

Closed by commit R318:853a95b6d5d2: Tighter match own service when trying to find suitable window to open path in. (authored by thomasp, committed by elvisangelaccio). · Explain WhyJun 3 2019, 7:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/global.cpp (3 lines)

Diff 59093

View Options

src/global.cpp

Loading...