Differential D21534

Move attendee UID generation out of IncidenceBase::addAttendee
ClosedPublic
Actions

Authored by vkrause on Jun 2 2019, 8:32 AM.

Details

Reviewers
dvratil
Commits
R172:7afb906ebcaf: Move attendee UID generation out of IncidenceBase::addAttendee
Summary

This prepares addAttendee for Attendee becoming a value type, as it no
longer relies on the pointer semantics to modify its argument on the
caller side too to add the UID.

Diff Detail

Repository
R172 KCalendar Core
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Jun 2 2019, 8:32 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptJun 2 2019, 8:32 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.Jun 2 2019, 8:32 AM
dvratil accepted this revision.Jun 2 2019, 12:56 PM
This revision is now accepted and ready to land.Jun 2 2019, 12:56 PM
Closed by commit R172:7afb906ebcaf: Move attendee UID generation out of IncidenceBase::addAttendee (authored by vkrause). · Explain WhyJun 3 2019, 5:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mautotests/testattendee.h (1 line)
Mautotests/testattendee.cpp (10 lines)
Msrc/attendee.cpp (12 lines)
Msrc/incidencebase.cpp (13 lines)

Diff 59082

View Options

autotests/testattendee.h

Loading...
View Options

autotests/testattendee.cpp

Loading...
View Options

src/attendee.cpp

Loading...
View Options

src/incidencebase.cpp

Loading...